Remove dead code from LocalExecutionPlanner.visitTableScan#29050
Merged
findepi merged 2 commits intotrinodb:masterfrom Apr 10, 2026
Conversation
Before the changes, the `visitTableScan` helper takes `filterExpression` which is effectively always TRUE. Additionally, the call from `visitFilter` is generally unreachable. There should be no FilterNode with trivial static condition and no dynamic filters. The commit removes the unreachable call and inlines now redundant helper.
findepi
added
the
no-release-notes
wendigo
approved these changes
Apr 9, 2026
raunaqmorarka
approved these changes
Apr 9, 2026
findepi
force-pushed
the
findepi/remove-dead-code-from-localexecutionplanner-visittablescan-4575eb
branch
from
c451c41 to
c6a7276
Compare
Remove the `DynamicFilter` parameter from `TableScanOperator`, as it is effectively always set to "no dynamic filter".
findepi
force-pushed
the
findepi/remove-dead-code-from-localexecutionplanner-visittablescan-4575eb
branch
from
c6a7276 to
013fbf2
Compare
findepi
deleted the
findepi/remove-dead-code-from-localexecutionplanner-visittablescan-4575eb
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the changes, the
visitTableScanhelper takesfilterExpressionwhich is effectively always TRUE. Additionally, the call fromvisitFilteris generally unreachable. There should be no FilterNode with trivial static condition and no dynamic filters. The commit removes the unreachable call and inlines now redundant helper.